Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MarkdownExporter ctor and Dialect protected #2407

Merged
merged 3 commits into from Aug 17, 2023
Merged

Make MarkdownExporter ctor and Dialect protected #2407

merged 3 commits into from Aug 17, 2023

Conversation

nietras
Copy link
Contributor

@nietras nietras commented Aug 17, 2023

Fixes #2399

adamsitnik
adamsitnik approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @nietras !

@timcassell timcassell merged commit 9da4497 into dotnet:master Aug 17, 2023
7 checks passed
@timcassell timcassell added this to the v0.13.8 milestone Aug 17, 2023
@nietras nietras deleted the markdownexporter-protected-ctor branch August 17, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsitnik adamsitnik adamsitnik approved these changes

Assignees
No one assigned
Labels
Area:Exporters
Projects
None yet
Milestone
v0.13.8
Development

Successfully merging this pull request may close these issues.

Custom MarkdownExporter
3 participants
@nietras @adamsitnik @timcassell