Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PlatformNotSupportedException thrown on Android in ConsoleTitler #2390

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Fix PlatformNotSupportedException thrown on Android in ConsoleTitler #2390

merged 2 commits into from
Aug 2, 2023

Commits on Aug 2, 2023

  1. Remove Immutable packages reference from Forms sample 

    BenchmarkDotNet has a dependency on Immutable 5.0.0 and this reference was causing package downgrade warnings:

```
error NU1605: Warning As Error: Detected package downgrade: System.Collections.Immutable from 5.0.0 to 1.7.0. Reference the package directly from the project to select a different version.
error NU1605:  BenchmarkDotNet.Samples.Forms -> BenchmarkDotNet -> Microsoft.Diagnostics.Runtime 2.2.332302 -> System.Collections.Immutable (>= 5.0.0)
error NU1605:  BenchmarkDotNet.Samples.Forms -> System.Collections.Immutable (>= 1.7.0)
error NU1605: Warning As Error: Detected package downgrade: System.Collections.Immutable from 5.0.0 to 1.7.0. Reference the package directly from the project to select a different version.
error NU1605:  BenchmarkDotNet.Samples.Forms -> BenchmarkDotNet -> Microsoft.CodeAnalysis.CSharp 4.1.0 -> Microsoft.CodeAnalysis.Common 4.1.0 -> System.Collections.Immutable (>= 5.0.0)
error NU1605:  BenchmarkDotNet.Samples.Forms -> System.Collections.Immutable (>= 1.7.0)
```
    @Adam--
    Adam-- committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    8bac667 View commit details
    Browse the repository at this point in the history

  2. Catch PlatformNotSupportedException when checking if console output i… 

    …s redirected in ConsoleTitler

Fixes dotnet#2389
    @Adam--
    Adam-- committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    d989b85 View commit details
    Browse the repository at this point in the history