Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building doc specifying .net 4.6.2 as requirement #2325

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

JobaDiniz
Copy link
Contributor

As I'm following the building documentation to locally build the project, I find out that .net 4.6.2 is required, not 4.6.1.

This aims to fix that documentation.

Signed-off-by: JobaDiniz <jobertodinizjunior@gmail.com>
@JobaDiniz
Copy link
Contributor Author

@dotnet-policy-service agree

@AndreyAkinshin
Copy link
Member

@JobaDiniz thanks for the PR!
While the 4.6.2 requirement looks reasonable, I'm curious about what kind of problem you experience with 4.6.1?
Also, since we are updating this page, it makes sense to update other versions as well to make the list of requirements consistent and up-to-date (it's been a while since the last page update). Would you mind doing this?

@JobaDiniz
Copy link
Contributor Author

The solution was not compiling if I only had 4.6.1 installed. I had to install 4.6.2.

Also, since we are updating this page, it makes sense to update other versions as well to make the list of requirements consistent and up-to-date.

I don't know what other requirements have changed. Any insights to find that out?

@AndreyAkinshin
Copy link
Member

@JobaDiniz I'm going to merge your PR and reevaluate the rest of the guide on my own. It's high time to check all the requirements and make them up-to-date. Thanks for the contribution!

@AndreyAkinshin AndreyAkinshin merged commit 88beb24 into dotnet:master Jun 13, 2023
5 checks passed
@JobaDiniz JobaDiniz deleted the docs/building branch June 13, 2023 18:20
@timcassell

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants