Fix PlatformNotSupportedException thrown on Android in ConsoleTitler #2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarkDotNet has a dependency on Immutable 5.0.0 and this reference was causing package downgrade warnings: ``` error NU1605: Warning As Error: Detected package downgrade: System.Collections.Immutable from 5.0.0 to 1.7.0. Reference the package directly from the project to select a different version. error NU1605: BenchmarkDotNet.Samples.Forms -> BenchmarkDotNet -> Microsoft.Diagnostics.Runtime 2.2.332302 -> System.Collections.Immutable (>= 5.0.0) error NU1605: BenchmarkDotNet.Samples.Forms -> System.Collections.Immutable (>= 1.7.0) error NU1605: Warning As Error: Detected package downgrade: System.Collections.Immutable from 5.0.0 to 1.7.0. Reference the package directly from the project to select a different version. error NU1605: BenchmarkDotNet.Samples.Forms -> BenchmarkDotNet -> Microsoft.CodeAnalysis.CSharp 4.1.0 -> Microsoft.CodeAnalysis.Common 4.1.0 -> System.Collections.Immutable (>= 5.0.0) error NU1605: BenchmarkDotNet.Samples.Forms -> System.Collections.Immutable (>= 1.7.0) ```
…s redirected in ConsoleTitler Fixes dotnet#2389
timcassell
approved these changes
Aug 2, 2023
|
Thanks @Adam--! |
adamsitnik
reviewed
Aug 3, 2023
There was a problem hiding this comment.
@Adam-- thank you for providing the fix! Also, it's really strange that Console.IsOutputRedirected throws on Android..
|
No problem, glad I could help! I see it was added to milestone 0.13.7, but wasn't sure what the release schedule is like. Do you know when it will be released or are there prereleases? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously on the Android platform, and possibly other platforms, the ConsoleTitler threw a PlatformNotSupportedException when checking if console output is redirected and prevented benchmarks from running. This is fixed by catching and ignoring the PlatformNotSupportedException. The try-catch around Console.Title is still used to determine if the platform supports console retitling. This seemed more appropriate in the event that the platform doesn't support checking if output is redirected but supports retitling, even though it is unlikely.
Additionally removes the Forms sample project's Immutable package reference. BenchmarkDotNet has a dependency on Immutable 5.0.0 and this reference was causing package downgrade warnings that were treated as errors:
Fixes #2389