Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix netcoreapp3.0 builds #2359

Merged
merged 4 commits into from Jul 10, 2023
Merged

Fix netcoreapp3.0 builds #2359

merged 4 commits into from Jul 10, 2023

Conversation

timcassell
Copy link
Collaborator

I got the wrong version of a nuget package in #2352.

@timcassell timcassell changed the title Fix netcoreapp3.0 builds for real Fix netcoreapp3.0 builds Jul 9, 2023
@timcassell timcassell linked an issue Jul 9, 2023 that may be closed by this pull request
@AndreyAkinshin
Copy link
Member

Why do we use different versions of Microsoft.CodeAnalysis.CSharp with different target frameworks? (4.2.0->4.1.0 with netstandard2.0 and 4.5.0 with net6.0)

@timcassell
Copy link
Collaborator Author

timcassell commented Jul 9, 2023

Why do we use different versions of Microsoft.CodeAnalysis.CSharp with different target frameworks? (4.2.0->4.1.0 with netstandard2.0 and 4.5.0 with net6.0)

Are you suggesting we just use the older version for all targets? I thought there was a reason someone updated them for net6.

@AndreyAkinshin
Copy link
Member

Previously, we used 3.0.0 but it caused compatibility issues in some cases. Therefore, it was updated to 4.5.0 (the latest version at the moment of update).
I believe that there is no perfect version of Microsoft.CodeAnalysis.CSharp since it would cause problems for those who use other versions of this package that are not compatible with our target version. However, I would prefer that we use the same version across all the target frameworks.

@AndreyAkinshin AndreyAkinshin merged commit e85fe28 into master Jul 10, 2023
12 checks passed
@AndreyAkinshin AndreyAkinshin deleted the fix-netcoreapp3.0 branch July 10, 2023 07:45
@AndreyAkinshin
Copy link
Member

@timcassell thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot benchmark netcoreapp3.0
2 participants