improve generation performance #8642
Merged
+50
−33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
graphql-codegen-cli/src/generate-and-save.ts
has more filesystem than neccessary:After reading the file from disk and generating the hash, the hash is not stored.
So if the
previousHash
matches thecurrentHash
the file will be read again from disk.mkdirp
is now built into nodeThis PR improves all three cases and in addition fixes a bug where
input.cwd
is not passed tomkdirp
.How Has This Been Tested?
All unit tests + tested on my machine - would love to get feedback from a windows user.
Test Environment:
@graphql-codegen/...
:Checklist: