Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grouping of changes #61

Merged
merged 2 commits into from Jan 26, 2021
Merged

Fix grouping of changes #61

merged 2 commits into from Jan 26, 2021

Conversation

tun0
Copy link
Contributor

@tun0 tun0 commented Jan 26, 2021

Make sure the changes output doesn't end up collapsed under the last "normal" output.

@dorny
Copy link
Owner

dorny commented Jan 26, 2021

Hello,

Thanks for the contribution!
Your fix in src/main.ts is of course correct.

However somehow you got quite different content of dist/index.js.
I'm pretty sure it's ncc issue. Maybe output depends on OS or node version... I don't know.
I build it again and updated PR. Now the diff of index.js matches what was changed.
Merging it. Thanks again 👍

@dorny dorny merged commit 363576b into dorny:master Jan 26, 2021
@tun0
Copy link
Contributor Author

tun0 commented Jan 26, 2021

However somehow you got quite different content of dist/index.js.
I'm pretty sure it's ncc issue. Maybe output depends on OS or node version... I don't know.

I noticed the same, but since this was my very first dabble in typescript and all that, I didn't dive in to it further. And by the time I created the PR, I had already forgotten about it, or I would've mentioned it in the PR itself.

Thanks for the rebuild & merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants