deprecate explicit cloud provider config for pull registries and retry credential verification #137
+45
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steved
force-pushed
the
steved/cloudprovider
branch
2 times, most recently
from
f5c0af3 to
4c21515
Compare
steved
force-pushed
the
steved/cloudprovider
branch
from
4c21515 to
f005365
Compare
steved
changed the title
fraenkel
approved these changes
Mar 29, 2024
fraenkel
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloud provider specification isn't necessary as we can either take the explicit secrets being passed or use a regex to attempt a cloud login.