Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOM-49106] Emit image size as part of build #131

Merged
merged 30 commits into from
Jan 19, 2024

Conversation

ddl-rliu
Copy link
Contributor

@ddl-rliu ddl-rliu commented Jan 4, 2024

Problem

When an image is built, we do not track the size of the image

Solution

Track the size and return it as compressedImageSizeBytes, part of the Annotations field in the BuildSucceeded response message at the end of a build.

We do this in Hephaestus, rather than Nucleus. This is because Nucleus does not talk with the registry; rather, it sets up the registry configs/auth and defers the responsibility to Hephaestus (which then defers it to buildkit). This PR queries the registry in order to track the size, and Hephaestus seems preferable since it is "closer" to buildkit.

https://dominodatalab.atlassian.net/browse/DOM-49106

  1. This PR does not handle multi-arch images. This (and the other below item) is tracked in a followup ticket https://dominodatalab.atlassian.net/browse/DOM-53850
  2. This PR only handles Hephaestus images.

@ddl-rliu ddl-rliu marked this pull request as draft January 5, 2024 18:57
@ddl-rliu ddl-rliu marked this pull request as ready for review January 18, 2024 23:22
@ddl-rliu ddl-rliu merged commit d1e6cd6 into main Jan 19, 2024
@ddl-rliu ddl-rliu deleted the rliu.DOM-49106.store-image-size2 branch January 19, 2024 19:23
fraenkel pushed a commit that referenced this pull request Feb 1, 2024
[DOM-49106] Emit image size bytes as part of build (#131)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants