Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move snapshots #3314

Merged
merged 2 commits into from
Mar 18, 2025
Merged

Move snapshots #3314

merged 2 commits into from
Mar 18, 2025

Conversation

martincostello
Copy link
Collaborator

Move all snapshots to their own directory and rename some of the tests to shorten the file names to avoid MAX_PATH issues on Windows.

Move all snapshots to their own directory and rename some of the tests to shorten the file names to avoid `MAX_PATH` issues on Windows.
@martincostello martincostello marked this pull request as ready for review March 18, 2025 14:20
Doesn't quite work.
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.56%. Comparing base (ecbb87f) to head (5d99438).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3314      +/-   ##
==========================================
- Coverage   84.86%   83.56%   -1.31%     
==========================================
  Files          77       77              
  Lines        3224     3224              
  Branches      559      559              
==========================================
- Hits         2736     2694      -42     
- Misses        488      530      +42     
Flag Coverage Δ
Linux 83.56% <ø> (ø)
Windows 83.56% <ø> (+17.21%) ⬆️
macOS 83.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martincostello martincostello enabled auto-merge (squash) March 18, 2025 14:26
@martincostello martincostello merged commit f8bcb7d into master Mar 18, 2025
9 checks passed
@martincostello martincostello deleted the move-snapshots branch March 18, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants