Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply IDE refactoring suggestions #3254

Merged
merged 2 commits into from
Mar 18, 2025
Merged

Apply IDE refactoring suggestions #3254

merged 2 commits into from
Mar 18, 2025

Conversation

martincostello
Copy link
Collaborator

Cherry-pick code refactoring/modernisation from #3252.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Cherry-pick code refactoring/modernisation from #3252.
@martincostello martincostello marked this pull request as ready for review February 6, 2025 10:38
@martincostello martincostello enabled auto-merge (rebase) February 6, 2025 10:38
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.56%. Comparing base (1433ce6) to head (eb03984).

Files with missing lines Patch % Lines
...ggerGen/SchemaGenerator/OpenApiSchemaExtensions.cs 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3254      +/-   ##
==========================================
- Coverage   83.56%   83.56%   -0.01%     
==========================================
  Files          76       76              
  Lines        3225     3224       -1     
  Branches      559      559              
==========================================
- Hits         2695     2694       -1     
  Misses        530      530              
Flag Coverage Δ
Linux 83.56% <92.85%> (-0.01%) ⬇️
Windows 83.56% <92.85%> (-0.01%) ⬇️
macOS 83.56% <92.85%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martincostello martincostello disabled auto-merge March 18, 2025 12:40
@martincostello martincostello enabled auto-merge (squash) March 18, 2025 12:40
@martincostello martincostello merged commit 1d7aed0 into master Mar 18, 2025
9 checks passed
@martincostello martincostello deleted the code-refactoring branch March 18, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants