Add social media icons #52
Conversation
|
Hmm. I'm not sure about that composition... There is no other navigation in the footer in the site's design; it's very out of place. To follow the design they would need to be in the top bar, but there isn't much room up there... maybe a dropdown? Could an alternative be sidebar widgets? I know twitter and facebook (assuming it doesn't do tracking evilness) have widgets that would be nice. I don't know about youtube however... All of the accounts are right btw! |
|
I can't think of sites that don't have the general social media links in the footer off the top of my head. Of course, share links and such are usually placed in a very prominent manner, but that's a wholly different use-case. Could you link any example sites you have in mind? |
|
But those sites follow a top nav + footer navigation style - dolphin-emu.org does not. dolphin-emu is straight up bootstrap, which was designed by twitter for... twitter, which is infinite scrolling (footers are impossible). Honestly dolphin-emu.org would really benefit from a footer navigation system. It would allow the top nav to be user facing things (forums, screenshots, guides, wiki, etc etc) while the footer can be more specific with things we are ok with not every user seeing (issue tracker, github pages, fifoci, dolp.in, all kinds of things that people have to memorize right now!) It would be a lot better than what we have now! But that would require an entirely new footer design to accomplish, though... And that is kind of beyond the scope of this PR... I don't really think placing the icons in the footer underneath the copyright notice is a good plan... It is against the design intentions of bootstrap, and it shows - discoverability is terrible! So, I think things should be done right with a proper footer, or stick to the boostrap design and put them in the top bar somehow (or in the page itself somehow, like the sidebars or how the google plus icon was handled?) |
|
By sidebars, you mean the wells in the front-page? (compability/ blog tags) Would they only exist on the front-page in that case? Where's the google plus icon located, I can't seem to find it. |
|
The +1 widget was removed. :P I did say "was handled"! If I remember correctly, it was placed beside the RSS icon. That's not the best place for it, but, it worked ok. As for the sidebar, yes the compatibility and blog tags are in it. No one actually uses a blog tag cloud, and it would be a loooot better to have a twitter sidebar there linked to various developers' twitter accounts and the official account, but meh. And a facebook like widget too. ...and whatever youtube has. But anyway, that's an alternative. |
|
I'm a bit confused, I must say. When you're talking about the google +1 and widgets, do you mean "Share" buttons for twitter and facebook and such? The way I understood the issue, it concerned a need for actual links to the various social media pages. |
|
With google+ it was kind of overlapping? Sorry, it's been a while... |
|
I think it makes sense putting the links in the footer. That's where I had expected they would go and seems to be pretty common on other sites to do it like that. I think there could be less space between the icons but otherwise it looks good to me. Also the Google+ page link is missing if it was intended to link to that too: https://plus.google.com/102301409253582998506 |
|
The Google+ page is no longer maintained, so it's probably best not to link to it... And I object to the "everyone else does it" line of logic. Because well, it's incorrect! Here are some examples of sites that use secondary footer navigation: Notice that none of them actually put their social media links down there! Discovery is too poor for that. Microsoft.com is a good example of how I'd think Dolphin could use footer sub-navigation - lots of misc links that don't need to have great discovery but are really nice to have, while the top navigation has primary navigation that has to be discovered and used by everyone. Aaaanyway, if you look at those sites, you'll notice that they don't have social media links in either top or bottom navigation! They are always presented in the page somewhere, via "Social media widgets" (satan!) and things. Still, links in the top bar, a proper footer, or something in the sidebar would be better. Especially the sidebar, since we could put more dynamic content there. @melonmanchan Sorry for going all designer over your PR... But I do think what is implemented here has very poor discovery. :( If you still want to put the links in the footer like you have now without making a full on footer sub-navigation, there are some ways to increase discovery. For a good example... look down! github's footer is nicely composed with nice margins (albeit with minimal discovery still...). To increase discovery from that, add to the margins even more, and make it a light grey color ala microsoft.com, and it just might work! |
|
I don't know if it's too late now but it would be nice to have these social media links ready for the 5.0 release, even if the implementation isn't 100% optimal. Currently it's a mess for users to tell which accounts are official and which ones are not. |
This PR adds twitter, facebook and youtube links to the page footer, as requested in issue #44. By the way, could someone double-check the links actually point to the right accounts? I'm not 100% sure.
Picture: https://i.imgur.com/zvUCgkK.png