VideoCommon: use imgui input queue for mouse clicks #12787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…input smooth regardless of frame-times and matches keyboard events, this system was introduced in 1.87
|
Seems correct to me looking at ocornut/imgui#4921 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In imgui 1.87 they introduced a new input system. One of the advantages of this input system was an input queuing system to keep input smooth when frame times were inconsistent. We switched over to this system for keyboard events when updating imgui as part of an interface breakage but we didn't update our mouse clicks to use this system.
This code updates our mouse handling to use the input event system.