-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove High Frequency Distortion and Prevent Crackling in Almost All Cases #12777
base: master
Are you sure you want to change the base?
Conversation
Audio is noticeably much worst with this PR. Lots of crackling and seems louder. |
This is a bug with the Audio Stretching, turn it off and you'll notice a big improvement. I will attempt to fix later. |
d099d41
to
503d710
Compare
Tested this PR again today.
W/o audio stretching:
Audio pitch aside, which is probably a subjective preference, this seems an improvement on all sides (I'll personally keep audio stretching on to avoid the pitch shift) |
190b829
to
57d5e68
Compare
Is this ready for another test (audio stretcher)? |
@dreamsyntax Yes I fixed the issue with the audio stretcher. Basically the amount of available samples that were actually available was being reported incorrectly, but that was fixed awhile ago. |
5e07322
to
222aa85
Compare
222aa85
to
ca22d0a
Compare
986d708
to
50e125d
Compare
2d309a9
to
734cf16
Compare
This PR now includes the changes from #12775 for the graphs
This can help stuff like this from happening in the future :)
Changes:
For some reason, Dolphin was using Linear interpolation for converting audio from 32000hz to 48000hz, this leads to extreme aliasing. The way you can tell there is aliasing is by looking at the high frequencies. In a good resampler, there should be no frequencies above the nyquist frequency (16000hz). Look at the spectrograms provided below, they show a clear improvement with the new resampler.
Photo with Direct Playback @ 20ms:
Photo with Audio Stretching @ 80ms:
Photo of Spectrogram @ Default Quality:
Photo of Spectrogram @ Placebo Quality: