AR codes applied through properties menu apply mid game

[icanquitwheneveriwant]

A stranger on discord I met today who I trust a lot said I should go ahead with this

[Pokechu22]

As far as I can tell, the only two places ARCodeWidget is created are:

dolphin/Source/Core/DolphinQt/CheatsManager.cpp

Line 137 in 7ba539d

m_ar_code = new ARCodeWidget(m_game_id, m_revision, false);

dolphin/Source/Core/DolphinQt/Config/PropertiesDialog.cpp

Line 43 in 7ba539d

ARCodeWidget* ar = new ARCodeWidget(game.GetGameID(), game.GetRevision());

I think it'd make more sense to completely remove m_restart_required and the restart_required parameter on the constructor.

[icanquitwheneveriwant]

yeah that's a good idea, I'm also removing the warning widget now

[AdmiralCurtiss]

Err, is there anything that guarantees that the codes you're editing are actually for the running game? There's nothing stopping you from, like, launching Wind Waker and then opening the Properties on Mario Sunshine, so there should be something that prevents actually applying cheats if you do that.

I wonder if that's why the flag was there in the first place.

[icanquitwheneveriwant]

Err, is there anything that guarantees that the codes you're editing are actually for the running game? There's nothing stopping you from, like, launching Wind Waker and then opening the Properties on Mario Sunshine, so there should be something that prevents actually applying cheats if you do that.

I wonder if that's why the flag was there in the first place.

Shit I didn't think of that, I'll try to fix that