Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: replace rpc module #42

Merged
merged 7 commits into from Oct 31, 2023
Merged

rpc: replace rpc module #42

merged 7 commits into from Oct 31, 2023

Conversation

0xcb9ff9
Copy link

0xcb9ff9 and others added 4 commits October 27, 2023 14:13
@0xcb9ff9
rpc: replace rpc module with go-ethereum/rpc
f5e2f34
@bnovil @0xcb9ff9
rpc: increase timeout in TestClientWebsocketPing (#28371)
2ed4325
@ajsutton @0xcb9ff9
rpc: use correct stringer-method for serializing BlockNumberOrHash (#…
f447582 
…28358)

The String() version of BlockNumberOrHash uses decimal for all block numbers, including negative ones used to indicate labels. Switch to using BlockNumber.String() which encodes it correctly for use in the JSON-RPC API.
@0xcb9ff9
fix: temporary fix unit tests
eb62342
@0xcb9ff9 0xcb9ff9 added the upstream upstream PR label Oct 30, 2023
@0xcb9ff9 0xcb9ff9 self-assigned this Oct 30, 2023
DarianShawn
DarianShawn reviewed Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got some questions.

eth/filters/filter.go Show resolved Hide resolved
DarianShawn
DarianShawn approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DarianShawn
DarianShawn approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the great work.

rpc/types.go Show resolved Hide resolved
@DarianShawn DarianShawn mentioned this pull request Oct 31, 2023
Open
3 tasks
@DarianShawn DarianShawn added this pull request to the merge queue Oct 31, 2023
Merged via the queue into dev with commit a7208a2 Oct 31, 2023
2 of 5 checks passed
@DarianShawn DarianShawn deleted the upstream/geth-rpc branch October 31, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarianShawn DarianShawn DarianShawn approved these changes

@abrahamcruise321 abrahamcruise321 Awaiting requested review from abrahamcruise321 abrahamcruise321 is a code owner

Assignees

@0xcb9ff9 0xcb9ff9

Labels
upstream upstream PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@0xcb9ff9 @DarianShawn @bnovil @ajsutton