Add types to EntityListenerResolver #9976
Merged
+27
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
types/listener-resolver
branch
from
92818ba to
c738233
Compare
SenseException
previously approved these changes
Aug 8, 2022
|
|
||
| /** | ||
| * Register a entity listener instance. | ||
| * | ||
| * @param object $object An entity listener | ||
| */ | ||
| public function register($object); | ||
| public function register(object $object): void; |
There was a problem hiding this comment.
Do you want to keep the arguments @param docblock?
There was a problem hiding this comment.
Not necessarily. I was unsure if it still provides value. What do you think? Remove?
derrabus
force-pushed
the
types/listener-resolver
branch
from
c738233 to
d25e285
Compare
SenseException
previously approved these changes
Aug 8, 2022
derrabus
force-pushed
the
types/listener-resolver
branch
from
d25e285 to
a1479db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9772