Fix fromMappingArray definition #11408
Merged
+151
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
fix/fromMappingArray
branch
2 times, most recently
from
473526a to
188f7ad
Compare
VincentLanglet
force-pushed
the
fix/fromMappingArray
branch
from
188f7ad to
1464827
Compare
greg0ire
approved these changes
Apr 3, 2024
SenseException
approved these changes
Apr 3, 2024
|
Thanks @VincentLanglet ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Kinda similar to #11226 @greg0ire @derrabus
I got a psalm error because
FieldMapping::fromMappingArraydoes not acceptnullablekey.This was because the array param was missing lot of keys.
I tried to fix the phpdoc of every fromMappingArray keys by looking at all the property of the class and allow them as array keys in the
$mappingArrayparameter.Thanks.