Deprecate obsolete and unnecessary properties from Table attribute (#11351) #11357
+54
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Mar 15, 2024
DaDeather
force-pushed
the
11351-add-deprecation-for-obsolete-indexes-and-unique-constraint-properties-of-table-attribute
branch
from
6224750 to
dbb7999
Compare
greg0ire
reviewed
Mar 15, 2024
DaDeather
force-pushed
the
11351-add-deprecation-for-obsolete-indexes-and-unique-constraint-properties-of-table-attribute
branch
from
dbb7999 to
6633f7b
Compare
…octrine#11351) The properties `indexes` and `uniqueConstraints` were used by the `AnnotationDriver` but were never implemented for the `AttributeDriver`. Since the `AnnotationDriver` doesn't exist anymore these can become deprecated and will then be removed afterwards.
DaDeather
force-pushed
the
11351-add-deprecation-for-obsolete-indexes-and-unique-constraint-properties-of-table-attribute
branch
from
6633f7b to
7d1444e
Compare
greg0ire
approved these changes
Mar 15, 2024
beberlei
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The properties
indexesanduniqueConstraintswere used by theAnnotationDriverbut were never implemented for theAttributeDriver. Since theAnnotationDriverdoesn't exist anymore these can become deprecated and will then be removed afterwards.