Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use EnumReflectionProperty class from persistence package #11330

Merged
merged 2 commits into from Mar 3, 2024
Merged

Use EnumReflectionProperty class from persistence package #11330

merged 2 commits into from Mar 3, 2024

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Mar 1, 2024 •
edited

It is meant to remove duplication between the ORM and the ODM.

@greg0ire

This comment was marked as resolved.

Sign in to view
@greg0ire

This comment was marked as resolved.

Sign in to view
@stof

This comment was marked as resolved.

Sign in to view
@greg0ire

This comment was marked as resolved.

Sign in to view
@greg0ire

This comment was marked as resolved.

Sign in to view
@greg0ire
Use class from persistence package
5a3adc1 
It is meant to remove duplication between the ORM and the ODM.
@greg0ire greg0ire marked this pull request as ready for review March 1, 2024 19:59
@greg0ire greg0ire changed the title Try using EnumReflectionProperty @greg0ire Use class from persistence package Mar 1, 2024
@greg0ire greg0ire changed the title @greg0ire Use class from persistence package Use class from persistence package Mar 1, 2024
stetodd
stetodd reviewed Mar 2, 2024
View reviewed changes
UPGRADE.md Outdated Show resolved Hide resolved
@derrabus @stetodd
Update UPGRADE.md
791cc0e 
Co-authored-by: Steve Todd <stodd@mashbo.com>
@derrabus derrabus added this to the 3.1.0 milestone Mar 3, 2024
@derrabus derrabus merged commit ba0ea89 into doctrine:3.1.x Mar 3, 2024
64 checks passed
derrabus added a commit that referenced this pull request Mar 3, 2024
@derrabus
Merge branch '3.1.x' into 4.0.x
a5cb7c2 
* 3.1.x:
  Use class from persistence package  (#11330)
  Refator array_map into simple loop for performance. (#11332)
@derrabus derrabus mentioned this pull request Mar 3, 2024
Merged
@derrabus derrabus changed the title Use class from persistence package Use EnumReflectionProperty class from persistence package Mar 3, 2024
@greg0ire greg0ire deleted the persistence-3-3 branch March 3, 2024 21:03
@greg0ire greg0ire mentioned this pull request Mar 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stetodd stetodd stetodd left review comments

@derrabus derrabus derrabus approved these changes

@SenseException SenseException Awaiting requested review from SenseException

Assignees
No one assigned
Labels
Deprecation
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@greg0ire @stof @derrabus @stetodd