Account for inversedBy being a non-falsy-string or null #11275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
reviewed
Feb 19, 2024
src/Mapping/OwningSideMapping.php
Outdated
| @@ -11,6 +11,8 @@ abstract class OwningSideMapping extends AssociationMapping | |||
| * The name of the field that completes the bidirectional association on | |||
| * the inverse side. This key must be specified on the owning side of a | |||
| * bidirectional association. | |||
| * | |||
| * @var non-falsy-string|null | |||
There was a problem hiding this comment.
The point of this PR was to eliminate the implicit casts of this property to a boolean, right? in that case, I don't understand why we would still need to point out that this string is not falsy.
There was a problem hiding this comment.
We don't need to, it's more something that is derived from the comment above it, and that makes the rest of the PR OK. Because it's a non falsy string, we don't need to replace the implicit cast with strict comparisons with '' or '0'.
There was a problem hiding this comment.
Removed it since it serves now purpose besides making this PR slightly easier to understand.
SenseException
previously approved these changes
Feb 19, 2024
It is supposed to hold the name of a PHP property, and those cannot be falsy strings.
greg0ire
force-pushed
the
sa-inversed-by
branch
from
53b5e8d
to
e0081b5
Compare
derrabus
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is supposed to hold the name of a PHP property, and those cannot be falsy strings.