[Documentation] Adding link to Postgres upgrade article #11257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwage
previously approved these changes
Feb 13, 2024
greg0ire
reviewed
Feb 13, 2024
UPGRADE.md
Outdated
|
|
||
| instead of `SEQUENCE`. | ||
| * If you want to upgrade your existing tables to `IDENTITY`, see [Migration to identity columns on PostgreSQL](https://www.doctrine-project.org/projects/doctrine-dbal/en/4.0/how-to/postgresql-identity-migration.html) | ||
| * If you want to keep `SEQUENCE` or `SERIAL`, then configure the ORM this way: |
There was a problem hiding this comment.
🤔 I understand what you mean by "keeping SEQUENCE", but what do you mean by "keeping SERIAL"?
There was a problem hiding this comment.
Maybe it's not clear to everybody that types SEQUENCE and SERIAL are the same (at least I didn't know that). I now added "type" - I guess that's what you mean, right?
There was a problem hiding this comment.
I think there are 3 concepts:
- Identifier generation strategies (
AUTO,IDENTITY,SEQUENCE, etc.) - What SQL object they map to (a database sequence, an auto-increment column, an identity column).
- The DDL used to create these objects (
SERIAL, which is no longer used with ORM 3 and DBAL 4,GENERATED ALWAYS AS IDENTITY, etc.)
I think people are very confused about this, so let's try hard not to increase the confusion, by not using these 3 concepts interchangeably.
* If you want to upgrade your existing tables to identity columns, you will need
to follow [migration to identity columns on PostgreSQL](https://www.doctrine-project.org/projects/doctrine-dbal/en/4.0/how-to/postgresql-identity-migration.html)
* If you want to keep using SQL sequences, you need to configure the ORM this way:There was a problem hiding this comment.
OK, take a look now.
There was a problem hiding this comment.
I did, and approved 👍
Just keeping that conversation open in case other maintainers disagree with my suggestion.
greg0ire
approved these changes
Feb 13, 2024
jwage
approved these changes
Feb 13, 2024
SenseException
approved these changes
Feb 15, 2024
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Feb 21, 2024
* 3.0.x: Remove broken assertion from DateAddFunction and DateSubFunction (doctrine#11243) Remove unused trait [Documentation] Adding link to Postgres upgrade article (doctrine#11257) fix: support array-type arg in QB variadic calls (doctrine#11242)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Feb 21, 2024
* 3.1.x: Fix Static Analysis folder reference (doctrine#11281) Remove broken assertion from DateAddFunction and DateSubFunction (doctrine#11243) Account for inversedBy being a non-falsy-string or null Improve static analysis on AttachEntityListenersListener docs: recommend safer way to disable logging (doctrine#11269) Remove unused baseline entries Treat '0' as a legitimate trim char Add type field mapper documentation to the sidebar Mark document as orphan Use correction sectionauthor syntax Remove unused trait [Documentation] Adding link to Postgres upgrade article (doctrine#11257) Validate more variadic parameters (doctrine#11261) Throw if a variadic parameter contains unexpected named arguments (doctrine#11260) Make docs valid according to guides 0.3.3 (doctrine#11252) fix: support array-type arg in QB variadic calls (doctrine#11242)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11248