Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatten directory tree on 2.18 #11148

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Flatten directory tree on 2.18 #11148

merged 1 commit into from
Jan 2, 2024

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Jan 2, 2024 •
edited

It will make fuzzy matchers more efficient, and configuration files more readable.

  • lib/Doctrine/ORM becomes just src
  • tests/Doctrine/ becomes just tests

Companion PR: #11140

@greg0ire
Flatten directory tree
073f2aa 
It will make fuzzy matchers more efficient, and configuration files more readable.

- lib/Doctrine/ORM becomes just src
- tests/Doctrine/ becomes just tests
@greg0ire greg0ire changed the title Flatten directory tree Flatten directory tree on 2.18 Jan 2, 2024
SenseException
SenseException approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like that there are affected files that need to be included by users with a direct path that could be considered a BC break. But it will affect open PRs that were created before this change.

@greg0ire
Copy link
Member Author

greg0ire commented Jan 2, 2024

@SenseException or @derrabus can you please approve #11140 ? I'd like to merge both in quick succession, and then perform a merge up

@greg0ire greg0ire merged commit d698929 into doctrine:2.18.x Jan 2, 2024
59 checks passed
@greg0ire greg0ire deleted the flatten branch January 2, 2024 20:54
@greg0ire greg0ire mentioned this pull request Jan 2, 2024
Merged
@greg0ire greg0ire added this to the 2.18.0 milestone Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
2.18.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@greg0ire @SenseException