Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests with PHP 8.4 #6528

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Run tests with PHP 8.4 #6528

merged 1 commit into from
Oct 2, 2024
+25 −0

Conversation

nickvergessen
Copy link
Contributor

Summary

  • Similar to Run tests with PHP 8.3 #6060
  • But not alpha-1 but rc-1 has been released already
  • I hope 3.9.x branch is okay. I didn't find a policy for which versions you plan to add new PHP versions, but we from Nextcloud would highly appreciate if it was the 3.9.x branch as we are still struggling with the update to 4.x

@derrabus derrabus added this to the 3.9.2 milestone Oct 2, 2024
greg0ire
greg0ire approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be squashed or squash-merged

@nickvergessen
ci: Run tests with PHP 8.4
Loading
Loading status checks…
f3754a8 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Contributor Author

squashed

@derrabus derrabus merged commit 8188dd6 into doctrine:3.9.x Oct 2, 2024
94 checks passed
derrabus added a commit that referenced this pull request Oct 9, 2024
@derrabus
Merge branch '4.1.x' into 4.2.x
Loading
Loading status checks…
79b257b 
* 4.1.x:
  Bump doctrine/.github from 5.1.0 to 5.2.0 (#6534)
  Fix broken link
  Setup documentation workflow
  Add cli-tools tools document to the TOC
  Avoid custom directives
  Mark sidebar as orphan
  ci: Run tests with PHP 8.4 (#6528)
  Bump GitHub actions (#6527)
derrabus added a commit that referenced this pull request Oct 9, 2024
@derrabus
Merge branch '4.2.x' into 5.0.x
Loading
Loading status checks…
c27943a 
* 4.2.x:
  Bump doctrine/.github from 5.1.0 to 5.2.0 (#6534)
  Fix broken link
  Setup documentation workflow
  Add cli-tools tools document to the TOC
  Avoid custom directives
  Mark sidebar as orphan
  ci: Run tests with PHP 8.4 (#6528)
  Bump GitHub actions (#6527)
@derrabus derrabus changed the title ci: Run tests with PHP 8.4 Run tests with PHP 8.4 Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire

Assignees
No one assigned
Labels
CI PHP
Projects
None yet
Milestone
3.9.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nickvergessen @greg0ire @derrabus