AbstractPlatform: allow any string in interval for date interval expression #6302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are going to be some CI failures, waiting for the workflow approval :) |
derrabus
previously approved these changes
Feb 9, 2024
|
Static analysis is failing as predicted. 🙂 |
ondrejmirtes
force-pushed
the
date-interval-any-string
branch
from
551ba19
to
ade652c
Compare
|
Alright, the 2nd commit backports the solution from DBAL 4.0 :) Let's run the workflows again. |
ondrejmirtes
force-pushed
the
date-interval-any-string
branch
from
ade652c
to
2c11ff3
Compare
|
The CS violation should be gone now. |
|
Alright, it's green :) Once this is merged and released, I'll update the DBAL version constraint doctrine/orm#11243 to require this new version. |
derrabus
approved these changes
Feb 12, 2024
derrabus
added a commit
that referenced
this pull request
Feb 13, 2024
* 3.8.x: [3.8.x] AbstractPlatform - allow any string in interval for date interval expression (#6302)
derrabus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change allows these methods to be called with just a
stringin ORM 3.0.x. See doctrine/orm#11243 (comment)DBAL 4.0.x already has
stringthere.Also I'd like to note that I noticed that methods
getDateAddQuartersExpressionandgetDateSubQuartersExpressionaren't called from ORM. Shouldn't support for them be added?