Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doctrine/persistence v4 support #1022

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Conversation

toniperic
Copy link

No description provided.

@greg0ire
Copy link
Member

Hi and thanks for working on this. May I ask why you're doing this though? The plan (although I don't think it's communicated clearly yet) is to retire and abandon doctrine/common. So… do you have a need that prompted this PR?

@toniperic
Copy link
Author

Hi @greg0ire, thanks for the notice. Had no idea that was the case.

As for the motivation: a project of mine depends on both doctrine/common and doctrine/persistence (currently v3).

Since doctrine/persistence v4 got released roughly ~2 months ago, I've wanted to upgrade to it, but Composer has been flagging dependency resolution issues as doctrine/common works only with v2 and v3, which makes doctrine/persistence v4 impossible to install.

Considering how easy of an upgrade it was to get doctrine/common to work with v4, decided to give it a go.

@greg0ire greg0ire changed the base branch from 3.4.x to 3.5.x December 31, 2024 10:11
@greg0ire greg0ire added this to the 3.5.0 milestone Dec 31, 2024
@greg0ire
Copy link
Member

greg0ire commented Dec 31, 2024

Re-targeted to 3.5.x as this is not a bugfix. I think we should release 3.5.0 shortly after merging, it contains #1002, which will improve communication about deprecated stuff you might be using.

@greg0ire greg0ire merged commit d9ea4a5 into doctrine:3.5.x Jan 1, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants