Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable SlevomatCodingStandard.TypeHints.ClassConstantTypeHint #327

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Feb 24, 2025

Based on

#325
#326

@simPod simPod changed the title feat: enable SlevomatCodingStandard.Classes.EnumCaseSpacing sniff feat: enable SlevomatCodingStandard.TypeHints.ClassConstantTypeHint Feb 24, 2025
@simPod simPod force-pushed the sniffie branch 10 times, most recently from 1f3d79a to 59ca9fa Compare February 24, 2025 08:29
@simPod simPod marked this pull request as ready for review February 24, 2025 08:30
@simPod simPod requested a review from a team as a code owner February 24, 2025 08:30
@simPod simPod mentioned this pull request Mar 20, 2025
greg0ire
greg0ire previously approved these changes Mar 20, 2025
morozov
morozov previously approved these changes Mar 20, 2025
@greg0ire greg0ire dismissed stale reviews from morozov and themself March 20, 2025 18:00

The merge-base changed after approval.

alcaeus
alcaeus previously approved these changes Mar 21, 2025
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with requiring a type

@simPod simPod force-pushed the sniffie branch 2 times, most recently from 17ad88b to dffad22 Compare March 21, 2025 12:24

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…niff
@greg0ire greg0ire merged commit ab80779 into doctrine:13.0.x Mar 21, 2025
14 checks passed
@greg0ire greg0ire added this to the 13.0.0 milestone Mar 21, 2025
@greg0ire
Copy link
Member

Thanks @simPod !

@simPod simPod deleted the sniffie branch March 21, 2025 13:54
@simPod
Copy link
Contributor Author

simPod commented Mar 21, 2025

That's all from me now 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants