FileCacheReader::saveCacheFile::unlink fix

[adammbalogh]

$tempfile is not correct because there's a rename func. call on $tempfile (to $path) before the unlink func. call

[stof]

This does not make sense. You are now deleting the cache file you are creating.

the unlink should actually be done in failure cases, before throwing the exceptions

[adammbalogh]

Yeah right :) my bad

But if the rename is successful, unlink won't find the $tempfile.
And if the rename is not successful, the interpreter won't reach unlink, isn't it?

[xabbuh]

@adammbalogh Just move the unlink into the if block right before the exception is thrown.

[adammbalogh]

@xabbuh agree
@stof ?

[stof]

👍

[Ocramius]

@adammbalogh thanks!

[oleg-andreyev]

When this fix will land in 1.2.4?

[krewetka]

👍

[GromNaN]

👍

Can you tag a 1.2.4 @Ocramius ?

[Ocramius]

Tagged.