Cover all directories with our tooling #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal is to hold new code with higher standards, and to have the same configuration on all branches. Since I have no proof addressing static analysis issues fixes any actual bugs, let us ignore them all on this branch.
derrabus
approved these changes
Mar 26, 2024
|
For 3.4? |
If we target 3.4 there is a risk we will have to tweak stuff related to CS or SA while merging up, so I'd rather we stick with 3.3. I ignored SA errors so that this is not controversial, so all the changes that happen in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to hold new code with higher standards, and to have the same configuration on all branches. Since I have no proof addressing static analysis issues fixes any actual bugs, let us ignore them all on this branch.
I initially wanted to modernize the directory structure just like in doctrine/DoctrineBundle#1767, but this needs to be done first.