Change type hint from Registry to ManagerRegistry in ProfilerController
#1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideally we should use |
changed |
dmaicher
approved these changes
Mar 7, 2024
|
@ostrolucky do we consider this a bugfix for 2.11.x? or an improvement for 2.12.x? |
|
Let's do 2.12. I can't see how is this a bugfix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code breaks decorating
ManagerRegistry.ProfilerControlleronly usesgetConnection()which is in the interface, so it is not a problem. And it is also the only remaining place in the package whereRegistryis used as the type hint instead ofManagerRegistry.