fix: replace classutils with doctrine/orm version #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ahummeling
force-pushed
the
fix/replace-classutils-with-default-proxy-name-resolver
branch
from
a37ec1b
to
051ab26
Compare
greg0ire
reviewed
Jan 25, 2024
composer.json
Outdated
| @@ -32,6 +32,7 @@ | |||
| "php": "^7.4 || ^8.0", | |||
| "doctrine/cache": "^1.11 || ^2.0", | |||
| "doctrine/dbal": "^3.7.0 || ^4.0", | |||
| "doctrine/orm": "^2.17 || ^3.0", | |||
There was a problem hiding this comment.
I don't think you should move this dependency here. When $this->container->getParameter('doctrine.orm.auto_generate_proxy_classes') is true, then it must mean doctrine/orm is installed, right?
There was a problem hiding this comment.
Oh, ofcourse, you're entirely correct. Moving this change back to require-dev, I do still think the version should be bumped, to avoid installing a version of ORM without the new class
Ahummeling
force-pushed
the
fix/replace-classutils-with-default-proxy-name-resolver
branch
from
051ab26
to
e5782b3
Compare
stof
requested changes
Jan 25, 2024
Ahummeling
force-pushed
the
fix/replace-classutils-with-default-proxy-name-resolver
branch
from
e5782b3
to
b5dee45
Compare
greg0ire
approved these changes
Jan 25, 2024
dmaicher
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1745
As discussed in #1746