Register PdoSessionHandlerSchemaSubscriber #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alli83
force-pushed
the
doctrine-bundle-add-config-pdo-session-handler-schema-subscriber
branch
2 times, most recently
from
4681eb8
to
7a00e16
Compare
Merged
3 tasks
ostrolucky
approved these changes
Oct 31, 2022
alli83
force-pushed
the
doctrine-bundle-add-config-pdo-session-handler-schema-subscriber
branch
from
7a00e16
to
2186954
Compare
nicolas-grekas
force-pushed
the
doctrine-bundle-add-config-pdo-session-handler-schema-subscriber
branch
from
2186954
to
133aeb0
Compare
nicolas-grekas
changed the title
There was a problem hiding this comment.
Thanks for this PR @alli83
I force-pushed on your fork to sync with changes I made on symfony/symfony#48059
Can you please have a look at CI failures, once my comment is resolved?
🙏
Thanks. yes, of course! |
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Dec 16, 2022
…en pdo handler is used (alli83) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [HttpFoundation] Create migration for session table when pdo handler is used | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | | License | MIT | Doc PR | The purpose of this PR is to automatically generate the session table with the make migration command in addition to https://symfony.com/doc/current/session/database.html#preparing-the-database-to-store-sessions Even though `WellKnownSchemaFilterPass` is deprecated, atm the session table is blacklisted by the `WellKnownSchemaFilterPass`, that's why I need to set the SchemaAssetFilter to null. todo: - [ ] doctrineBundle => doctrine/DoctrineBundle#1569 - [x] Add mention to changelog - [ ] update documentation Commits ------- aebdc58 [HttpFoundation] Create migration for session table when pdo handler is used
symfony-splitter
pushed a commit
to symfony/http-foundation
that referenced
this pull request
Dec 16, 2022
…en pdo handler is used (alli83) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [HttpFoundation] Create migration for session table when pdo handler is used | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | | License | MIT | Doc PR | The purpose of this PR is to automatically generate the session table with the make migration command in addition to https://symfony.com/doc/current/session/database.html#preparing-the-database-to-store-sessions Even though `WellKnownSchemaFilterPass` is deprecated, atm the session table is blacklisted by the `WellKnownSchemaFilterPass`, that's why I need to set the SchemaAssetFilter to null. todo: - [ ] doctrineBundle => doctrine/DoctrineBundle#1569 - [x] Add mention to changelog - [ ] update documentation Commits ------- aebdc581fa [HttpFoundation] Create migration for session table when pdo handler is used
symfony-splitter
pushed a commit
to symfony/cache
that referenced
this pull request
Dec 16, 2022
…en pdo handler is used (alli83) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [HttpFoundation] Create migration for session table when pdo handler is used | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | | License | MIT | Doc PR | The purpose of this PR is to automatically generate the session table with the make migration command in addition to https://symfony.com/doc/current/session/database.html#preparing-the-database-to-store-sessions Even though `WellKnownSchemaFilterPass` is deprecated, atm the session table is blacklisted by the `WellKnownSchemaFilterPass`, that's why I need to set the SchemaAssetFilter to null. todo: - [ ] doctrineBundle => doctrine/DoctrineBundle#1569 - [x] Add mention to changelog - [ ] update documentation Commits ------- aebdc581fa [HttpFoundation] Create migration for session table when pdo handler is used
symfony-splitter
pushed a commit
to symfony/doctrine-bridge
that referenced
this pull request
Dec 16, 2022
…en pdo handler is used (alli83) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [HttpFoundation] Create migration for session table when pdo handler is used | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | | License | MIT | Doc PR | The purpose of this PR is to automatically generate the session table with the make migration command in addition to https://symfony.com/doc/current/session/database.html#preparing-the-database-to-store-sessions Even though `WellKnownSchemaFilterPass` is deprecated, atm the session table is blacklisted by the `WellKnownSchemaFilterPass`, that's why I need to set the SchemaAssetFilter to null. todo: - [ ] doctrineBundle => doctrine/DoctrineBundle#1569 - [x] Add mention to changelog - [ ] update documentation Commits ------- aebdc581fa [HttpFoundation] Create migration for session table when pdo handler is used
|
Upsteam is now merged :) |
alli83
force-pushed
the
doctrine-bundle-add-config-pdo-session-handler-schema-subscriber
branch
2 times, most recently
from
97e4d55
to
ac6361b
Compare
ostrolucky
removed
the
Status: On Hold
alli83
force-pushed
the
doctrine-bundle-add-config-pdo-session-handler-schema-subscriber
branch
2 times, most recently
from
ebcb76d
to
930a708
Compare
alli83
force-pushed
the
doctrine-bundle-add-config-pdo-session-handler-schema-subscriber
branch
2 times, most recently
from
29c077f
to
9699326
Compare
alli83
force-pushed
the
doctrine-bundle-add-config-pdo-session-handler-schema-subscriber
branch
from
9699326
to
779da5a
Compare
nicolas-grekas
approved these changes
Dec 21, 2022
|
I this ready to be merged or do we wait for the 6.3 release? |
|
It seems safe to merge it given the conditional removal of the definition |
|
I was thinking of maybe adding some documentation but I don't think it belongs here so I will make an other PR on symfony-docs repo instead |
Documentation regarding this bundle is maintain in this repository. Don't hesitate to add it to the PR. |
What I don't understand (if it's possible to enlighten me) is that the changes made on the WellKnownSchemaFilterPass is more of an "internal operation" that will depend on what has been done on the PdoSessionHandlerSchemaSubscriber and consequently on the PdoSessionHandler Class in the Symfony repo. I'm having a little trouble understanding the point of the documentation at this level. |
ostrolucky
approved these changes
Dec 30, 2022
ostrolucky
removed
the
Status: On Hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
link to PR symfony/symfony#48059