feat: allows to specify context to fetch git data #248

neilime · 2022-12-15T13:46:53Z

Add context input to specify where to get context data. Allowed options are: "workflow" (default), "git".

`workflow` context

context: workflow

sha: context.sha
ref: context.ref

`git` context

Will get Git context from previously checkout repository. @see https://github.com/actions/checkout

context: git

sha: git rev rev-parse HEAD
ref: git symbolic-ref HEAD

fredleger · 2022-12-19T09:51:32Z

We also ran into an issue that can be fixed by this PR. From my point of view it makes totally sense

crazy-max · 2022-12-19T10:13:31Z

Thanks for your contrib, I think you can squash your commits and also fix DCO, see https://github.com/docker/metadata-action/pull/248/checks?check_run_id=10165522880

neilime · 2022-12-19T11:24:20Z

Thanks for your contrib, I think you can squash your commits and also fix DCO, see https://github.com/docker/metadata-action/pull/248/checks?check_run_id=10165522880

Done @crazy-max

src/context.ts

README.md

neilime · 2023-01-16T13:27:08Z

@crazy-max, need your approval to run workflow and your review.

Thanks

qwqcode · 2023-01-25T17:29:25Z

This PR solves the problem I'm having perfectly, I'd really appreciate it if could be merged soon. 😁

crazy-max

Thanks for updating with latest actions-toolkit release. See my comments.

See also ci failure: https://github.com/docker/metadata-action/actions/runs/4323012276/jobs/7547788506#step:4:5637

package.json

action.yml

README.md

neilime · 2023-03-30T09:42:55Z

@crazy-max, feedbacks are resolved and tests fixed, can you have a look please.

crazy-max

Some nits and should be good after that

__tests__/meta.test.ts

src/context.ts

README.md

Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>

crazy-max

LGTM thanks!

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [docker/metadata-action](https://togithub.com/docker/metadata-action) | action | minor | `v4.3.0` -> `v4.4.0` | --- ### Release Notes <details> <summary>docker/metadata-action</summary> ### [`v4.4.0`](https://togithub.com/docker/metadata-action/releases/tag/v4.4.0) [Compare Source](https://togithub.com/docker/metadata-action/compare/v4.3.0...v4.4.0) - Add `context` input to define the metadata provider by [@neilime](https://togithub.com/neilime) in [docker/metadata-action#248 - Switch to actions-toolkit implementation by [@crazy-max](https://togithub.com/crazy-max) in [docker/metadata-action#266 [docker/metadata-action#273 [docker/metadata-action#284 - Bump csv-parse from 5.3.3 to 5.3.8 in [docker/metadata-action#271 [docker/metadata-action#286 - Bump moment-timezone from 0.5.40 to 0.5.43 in [docker/metadata-action#268 [docker/metadata-action#278 [docker/metadata-action#281 - Bump semver from 7.4.0 to 7.5.0 in [docker/metadata-action#285 **Full Changelog**: docker/metadata-action@v4.3.0...v4.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/swissgrc/.github).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Upgrades the action to 96383f45573cb7f253c731d3b3ab81c87ef81934 # v5.0.0 Release notes: Release notes Sourced from docker/metadata-action's releases. v5.0.0 Node 20 as default runtime (requires Actions Runner v2.308.0 or later) by @crazy-max in docker/metadata-action#328 Bump @actions/core from 1.10.0 to 1.10.1 in docker/metadata-action#333 Bump csv-parse from 5.4.0 to 5.5.0 in docker/metadata-action#320 Bump semver from 7.5.1 to 7.5.2 in docker/metadata-action#304 Bump handlebars from 4.7.7 to 4.7.8 in docker/metadata-action#315 Full Changelog: docker/metadata-action@v4.6.0...v5.0.0 v4.6.0 Dedup and sort labels by @crazy-max in docker/metadata-action#301 Bump @docker/actions-toolkit from 0.3.0 to 0.5.0 in docker/metadata-action#302 Full Changelog: docker/metadata-action@v4.5.0...v4.6.0 v4.5.0 Bump @docker/actions-toolkit from 0.1.0 to 0.3.0 in docker/metadata-action#296 Bump csv-parse from 5.3.8 to 5.4.0 in docker/metadata-action#294 Full Changelog: docker/metadata-action@v4.4.0...v4.5.0 v4.4.0 Add context input to define the metadata provider by @neilime in docker/metadata-action#248 Switch to actions-toolkit implementation by @crazy-max in docker/metadata-action#266 docker/metadata-action#273 docker/metadata-action#284 Bump csv-parse from 5.3.3 to 5.3.8 in docker/metadata-action#271 docker/metadata-action#286 Bump moment-timezone from 0.5.40 to 0.5.43 in docker/metadata-action#268 docker/metadata-action#278 docker/metadata-action#281 Bump semver from 7.4.0 to 7.5.0 in docker/metadata-action#285 Full Changelog: docker/metadata-action@v4.3.0...v4.4.0 v4.3.0 Provide outputs as env vars by @crazy-max (#257) Full Changelog: docker/metadata-action@v4.2.0...v4.3.0 v4.2.0 Add tz attribute to handlebar date function by @chroju (#251) Bump minimatch from 3.0.4 to 3.1.2 (#242) Bump csv-parse from 5.3.1 to 5.3.3 (#245) Bump json5 from 2.2.0 to 2.2.3 (#252) Full Changelog: docker/metadata-action@v4.1.1...v4.2.0 v4.1.1 Revert changes to set associated head sha on pull request event by @crazy-max (#239) User can still set associated head sha on PR by setting the env var DOCKER_METADATA_PR_HEAD_SHA=true Bump csv-parse from 5.3.0 to 5.3.1 (#237) Full Changelog: docker/metadata-action@v4.1.0...v4.1.1 ... (truncated) Ref #2332

* Bump docker/build-push-action from 4 to 5 Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 4 to 5. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v4...v5) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * deps(gha): use commit id for docker/build-push-action version * deps(gha): use commit id for docker/login-action version * deps(gha): use commit id for docker/metadata-action version Upgrades the action to 96383f45573cb7f253c731d3b3ab81c87ef81934 # v5.0.0 Release notes: Release notes Sourced from docker/metadata-action's releases. v5.0.0 Node 20 as default runtime (requires Actions Runner v2.308.0 or later) by @crazy-max in docker/metadata-action#328 Bump @actions/core from 1.10.0 to 1.10.1 in docker/metadata-action#333 Bump csv-parse from 5.4.0 to 5.5.0 in docker/metadata-action#320 Bump semver from 7.5.1 to 7.5.2 in docker/metadata-action#304 Bump handlebars from 4.7.7 to 4.7.8 in docker/metadata-action#315 Full Changelog: docker/metadata-action@v4.6.0...v5.0.0 v4.6.0 Dedup and sort labels by @crazy-max in docker/metadata-action#301 Bump @docker/actions-toolkit from 0.3.0 to 0.5.0 in docker/metadata-action#302 Full Changelog: docker/metadata-action@v4.5.0...v4.6.0 v4.5.0 Bump @docker/actions-toolkit from 0.1.0 to 0.3.0 in docker/metadata-action#296 Bump csv-parse from 5.3.8 to 5.4.0 in docker/metadata-action#294 Full Changelog: docker/metadata-action@v4.4.0...v4.5.0 v4.4.0 Add context input to define the metadata provider by @neilime in docker/metadata-action#248 Switch to actions-toolkit implementation by @crazy-max in docker/metadata-action#266 docker/metadata-action#273 docker/metadata-action#284 Bump csv-parse from 5.3.3 to 5.3.8 in docker/metadata-action#271 docker/metadata-action#286 Bump moment-timezone from 0.5.40 to 0.5.43 in docker/metadata-action#268 docker/metadata-action#278 docker/metadata-action#281 Bump semver from 7.4.0 to 7.5.0 in docker/metadata-action#285 Full Changelog: docker/metadata-action@v4.3.0...v4.4.0 v4.3.0 Provide outputs as env vars by @crazy-max (#257) Full Changelog: docker/metadata-action@v4.2.0...v4.3.0 v4.2.0 Add tz attribute to handlebar date function by @chroju (#251) Bump minimatch from 3.0.4 to 3.1.2 (#242) Bump csv-parse from 5.3.1 to 5.3.3 (#245) Bump json5 from 2.2.0 to 2.2.3 (#252) Full Changelog: docker/metadata-action@v4.1.1...v4.2.0 v4.1.1 Revert changes to set associated head sha on pull request event by @crazy-max (#239) User can still set associated head sha on PR by setting the env var DOCKER_METADATA_PR_HEAD_SHA=true Bump csv-parse from 5.3.0 to 5.3.1 (#237) Full Changelog: docker/metadata-action@v4.1.0...v4.1.1 ... (truncated) Ref #2332 * deps(gha): upgrade the setup-buildx-action to v3.0.0 Uses commit id for docker/setup-buildx-action version Release notes at https://github.com/docker/setup-buildx-action/releases/tag/v3.0.0 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julio <1953782+julio-lopez@users.noreply.github.com>

neilime requested a review from crazy-max as a code owner December 15, 2022 13:46

neilime marked this pull request as draft December 15, 2022 13:47

neilime marked this pull request as ready for review December 18, 2022 05:09

crazy-max requested changes Dec 19, 2022

View reviewed changes

src/context.ts Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

neilime requested a review from crazy-max December 20, 2022 09:48

crazy-max mentioned this pull request Feb 25, 2023

git: alternative github context and additional methods docker/actions-toolkit#55

Merged

crazy-max requested changes Mar 3, 2023

View reviewed changes

package.json Outdated Show resolved Hide resolved

action.yml Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

crazy-max requested changes Mar 30, 2023

View reviewed changes

__tests__/meta.test.ts Show resolved Hide resolved

src/context.ts Outdated Show resolved Hide resolved

src/context.ts Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

feat: allows to specify context to fetch git data

8f8c795

Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>

crazy-max approved these changes Mar 30, 2023

View reviewed changes

crazy-max merged commit 1ce9422 into docker:master Mar 30, 2023
27 checks passed

qwqcode mentioned this pull request Aug 22, 2023

refactor(CI): replace using metadata-action for the docker push ArtalkJS/Artalk#545

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: allows to specify context to fetch git data #248

feat: allows to specify context to fetch git data #248

neilime commented Dec 15, 2022 •

edited

fredleger commented Dec 19, 2022

crazy-max commented Dec 19, 2022

neilime commented Dec 19, 2022

neilime commented Jan 16, 2023 •

edited

qwqcode commented Jan 25, 2023 •

edited

crazy-max left a comment •

edited

neilime commented Mar 30, 2023

crazy-max left a comment

crazy-max left a comment

feat: allows to specify context to fetch git data #248

feat: allows to specify context to fetch git data #248

Conversation

neilime commented Dec 15, 2022 • edited

workflow context

git context

fredleger commented Dec 19, 2022

crazy-max commented Dec 19, 2022

neilime commented Dec 19, 2022

neilime commented Jan 16, 2023 • edited

qwqcode commented Jan 25, 2023 • edited

crazy-max left a comment • edited

Choose a reason for hiding this comment

neilime commented Mar 30, 2023

crazy-max left a comment

Choose a reason for hiding this comment

crazy-max left a comment

Choose a reason for hiding this comment

neilime commented Dec 15, 2022 •

edited

`workflow` context

`git` context

neilime commented Jan 16, 2023 •

edited

qwqcode commented Jan 25, 2023 •

edited

crazy-max left a comment •

edited