feat: bump to use node20 runtime, actions/checkout to v4 #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
crazy-max
reviewed
Sep 5, 2023
| @@ -26,6 +26,6 @@ inputs: | |||
| required: false | |||
|
|
|||
| runs: | |||
| using: 'node16' | |||
| using: 'node20' | |||
There was a problem hiding this comment.
We can't just bump to node20, we also need to align dev dependencies and update our toolkit.
Also I don't know why GitHub made a such drastic bump and didn't update to the latest LTS node 18 instead: https://nodejs.dev/en/about/releases/
Some users already complain: actions/checkout@97a652b
Anyway I will look into it and keep you posted. Closing in the meantime but thanks for your input.
There was a problem hiding this comment.
We can't just bump to node20, we also need to align dev dependencies and update our toolkit.
Noted, thanks. Feel free to close my other PRs too (if necessary).
Also I don't know why GitHub made a such drastic bump and didn't update to the latest LTS node
Same here
This was referenced Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Node 16 reaches the end of life soon on 11 Sep 2023. This PR updates the default runtime to
node20(Node 20) (actions/runner#2732). I have also bumped the actions/checkout version to v4 for the same.A major version bump might be needed after the PRs merge.
Closes #589