Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] common.mk: document some variables to prevent merge-conflicts #999

Merged
merged 1 commit into from Mar 6, 2024

Conversation

thaJeztah
Copy link
Member

Both the DOCKER_COMPOSE_REF and DOCKER_BUILDX_REF versions are frequently updated, which made it more likely to run into merge conflicts when pull requests are merged to update either.

Add a comment in between to reduce the probability for such PRs to conflict.

@thaJeztah
Copy link
Member Author

@milas @vvoland PTAL 🤗

vvoland
vvoland previously approved these changes Mar 6, 2024
milas
milas previously approved these changes Mar 6, 2024
Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

common.mk Outdated Show resolved Hide resolved
common.mk Outdated Show resolved Hide resolved
Both the DOCKER_COMPOSE_REF and DOCKER_BUILDX_REF versions are frequently
updated, which made it more likely to run into merge conflicts when
pull requests are merged to update either.

Add a comment in between to reduce the probability for such PRs to
conflict.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah merged commit 2153396 into docker:master Mar 6, 2024
6 checks passed
@thaJeztah thaJeztah deleted the add_comments branch March 6, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants