[master] Build Fedora 39 RPM packages

[p5]

Part of #939

Fedora 39 is currently in beta, but it would be great if you could build Docker binaries and publish them to the official Docker repositories - https://download.docker.com/linux/fedora/ - under nightly or test.

This is a complete stab in the dark at adding this. I have no idea how the builds work behind the scenes, but this feels like a good place to start.

This should be similar to @thaJeztah's commit for containerd
docker/containerd-packaging@9c8d391

Note:
I have not installed the releases built with this, but have confirmed make fedora-39 is successful using my ARM64 system. Not confirmed using aarch

[Romain-Geissler-1A]

Given how this repository works (I think this will need to be backported at least to branch 23), I advise you to squash all your commits into a single one (to ease cherry-picking in other branches).

[p5]

Given how this repository works (I think this will need to be backported at least to branch 23), I advise you to squash all your commits into a single one (to ease cherry-picking in other branches).

@Romain-Geissler-1A Thanks for the advice. After a couple attempts, the commits are now squashed into one.

[thaJeztah]

Thanks! Changes LGTM, and now that we have containerd.io packages up for Fedora 39, CI should probably go green.

Unfortunately, the Jenkins security settings only picks up changes to the Jenkinsfile from users with write access, so to run your changes, I'll have to push a quick PR with your changes with my account; if that passes, I can merge your PR.

Give me a minute, and I'll push a new PR from your branch (given that it will be the exact same commit, we can keep this one open, and merge once that passes).

[thaJeztah]

• PR is here; verifying "Enable Docker CE builds for Fedora 39" #943

I think this will need to be backported at least to branch 23

It's "ok" to cherry-pick, but I should mention that Docker may not be building/pushing new patch releases for the v23.0.x release. That said, it's fine to cherry-pick if someone wants to use that branch to build packages with.

[p5]

I see the cross-mac build failed with "docker login failed", which sounds unrelated to my changes. Maybe a rerun could help if this is not an expected error?
I would be suprised if this was related to my changes since I haven't touched any docker auth logic but am happy to investigate further if this is an unexpected result.

Rerun seems to have worked, thanks!

[thaJeztah]

Ah! Yes, I saw one of the stages fail on something unrelated, but wanted to wait for it to finish (as it spins up 35+ machines, so it's faster to re-run than to spin up 35 new machines 😂)

[thaJeztah]

In either case; it did run the fedora 39 builds, and CI looks happy, so let me bring this one in!

After this, we still need to make changes in our internal pipeline to enable builds for Fedora 39, but at least this repository now has the "recipes" to do so, thanks! 👍

[thaJeztah]

LGTM

[p5]

Is there anything I can do to help with publishing these packages?

Right now we're pinning the package to the one from the F38 repo for all F38 and F39 builds, which works currently, but it would be good to use packages that are built with F39 in our F39 image
https://github.com/ublue-os/bluefin/blob/main/dx/etc/yum.repos.d/docker-ce.repo#L3

[thaJeztah]

Packages will be published with the first docker engine (patch) release that will be done; I don't think there's a date yet for upcoming patch releases. The release pipeline currently does not allow for additional packages (new distros / distro versions) to be added in between releases (but something that's actively being worked on)

[Romain-Geissler-1A]

Fedora 39 is scheduled to be released on 17th of October and will become the "latest" Fedora. Will there be a patch release of Moby 24 before that moment ?