Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Golang to 1.21 #10890

Merged
merged 1 commit into from
Aug 10, 2023
Merged

upgrade Golang to 1.21 #10890

merged 1 commit into from
Aug 10, 2023

Conversation

glours
Copy link
Contributor

@glours glours commented Aug 10, 2023

What I did
Bump Golang to version 1.21

Related issue
N/A

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

Dockerfile Outdated Show resolved Hide resolved
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@glours glours merged commit 0baf24a into docker:main Aug 10, 2023
23 checks passed
@cpuguy83
Copy link
Contributor

Why?
Please add reasons why this is changed not just that it's changed, that's plain to see from the code that there's a change.

@ndeloof
Copy link
Contributor

ndeloof commented Sep 28, 2023

@cpuguy83 why would we want to keep an older version ?

@cpuguy83
Copy link
Contributor

Bumping the go.mod means everyone who compiles it has to bump the go version.
What would you not support a still in-support go version?

Anyway, the point is not to say "you shouldn't have done this" but "what's the reason for the decision?".

@ndeloof
Copy link
Contributor

ndeloof commented Sep 28, 2023

everyone who compiles it has to bump the go version

obviously! But if you exclude a few Linux distribution maintainers who have to compile on their own, the many others just consume Docker Compose as a pre-built binary and aren't affected.

what's the reason for the decision?

because we want to rely on latest available and can benefits potential optimizations or new constructs it offers. We don't wait to see a coding opportunity to bump version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants