trace: do not block connecting to OTLP endpoint #10882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milas
requested review from
a team,
nicksieger,
ndeloof,
StefanScherer,
ulyssessouza,
glours and
laurazard
and removed request for
a team
nicksieger
approved these changes
Aug 4, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10882 +/- ##
==========================================
- Coverage 58.81% 58.77% -0.04%
==========================================
Files 120 120
Lines 10454 10453 -1
==========================================
- Hits 6148 6144 -4
- Misses 3706 3708 +2
- Partials 600 601 +1
☔ View full report in Codecov by Sentry. |
This was left over from debugging, but we should not block. OTel will handle the connection in the background. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Remove the call to enable blocking when doing the gRPC dial for OTel.
This was left over from debugging, but we should not block. OTel will handle the connection in the background.
(not mandatory) A picture of a cute animal, if possible in relation to what you did
