Display builder's name on the first build line. #10881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvin-lubecki
force-pushed
the
display-builder-name
branch
from
dbf7456
to
2bea750
Compare
ndeloof
approved these changes
Aug 4, 2023
Code borrowed from buildx commands/build.go. Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
silvin-lubecki
force-pushed
the
display-builder-name
branch
from
2bea750
to
0a9d127
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10881 +/- ##
==========================================
+ Coverage 58.85% 58.87% +0.02%
==========================================
Files 120 120
Lines 10438 10448 +10
==========================================
+ Hits 6143 6151 +8
- Misses 3694 3698 +4
+ Partials 601 599 -2
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added on the top right side the builder name, to get the same UX as buildx.
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did
