Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve shell completion for --project-directory #10879

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

relrelb
Copy link
Contributor

@relrelb relrelb commented Aug 3, 2023

Currently docker compose --project-directory <tab> completes file names as well even though this option is invalid.
Restrict --project-directory completion to offer directory names only.

Signed-off-by: Ariel Bachar <relrelb@users.noreply.github.com>
Signed-off-by: relrelb <relrelb@users.noreply.github.com>
@relrelb relrelb force-pushed the project_directory_completion branch from f3c50c8 to 8a4095b Compare August 3, 2023 20:42
@milas milas self-assigned this Aug 10, 2023
@milas milas requested review from a team, nicksieger, ndeloof, StefanScherer, ulyssessouza, glours, milas and laurazard and removed request for a team August 10, 2023 12:59
Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution

@glours glours enabled auto-merge August 10, 2023 13:02
@glours glours merged commit 5bbdf3d into docker:main Aug 10, 2023
23 checks passed
@relrelb relrelb deleted the project_directory_completion branch August 10, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants