watch: enable tar-based syncer by default #10877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milas
requested review from
nicksieger,
ndeloof,
StefanScherer,
ulyssessouza,
glours and
laurazard
and removed request for
a team
Swap the default implementation now that batching is merged. Keeping the `docker cp` based implementation around for the moment, but it needs to be _explicitly_ disabled now by setting `COMPOSE_EXPERIMENTAL_WATCH_TAR=0`. After the next release, we should remove the `docker cp` implementation entirely. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
milas
force-pushed
the
watch-enable-tar
branch
2 times, most recently
from
c943de3
to
d65c4b9
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10877 +/- ##
==========================================
- Coverage 58.85% 58.84% -0.01%
==========================================
Files 120 120
Lines 10438 10444 +6
==========================================
+ Hits 6143 6146 +3
- Misses 3694 3698 +4
+ Partials 601 600 -1
☔ View full report in Codecov by Sentry. |
ndeloof
approved these changes
Aug 4, 2023
milas
added a commit
to milas/compose
that referenced
this pull request
Aug 4, 2023
Swap the default implementation now that batching is merged. Keeping the `docker cp` based implementation around for the moment, but it needs to be _explicitly_ disabled now by setting `COMPOSE_EXPERIMENTAL_WATCH_TAR=0`. After the next release, we should remove the `docker cp` implementation entirely. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Swap the default implementation now that batching is merged. Keeping the
docker cpbased implementation around for the moment, but it needs to be explicitly disabled now by settingCOMPOSE_EXPERIMENTAL_WATCH_TAR=0.After the next release, we should remove the
docker cpimplementation entirely.(not mandatory) A picture of a cute animal, if possible in relation to what you did
