up: do not warn on successful optional dependency complete #10870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milas
requested review from
nicksieger,
ndeloof,
StefanScherer,
ulyssessouza,
glours and
laurazard
and removed request for
a team
ndeloof
approved these changes
Aug 3, 2023
If an optional dependency exits successfully (exit code of 0), with a service condition of `service_completed_successfully`, don't log a warning. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
milas
force-pushed
the
required-cond-exit-warning
branch
from
aa87f3f
to
4e69e87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
If an optional dependency exits successfully (exit code of 0), with a service condition of
service_completed_successfully, don't log a warning.Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did
