Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli/command: move PrettyPrint utility to cli/command/formatter #5916

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Mar 9, 2025

This utility was only used internally, and has no external consumers; move it to the "formatter" package, which is also imported in all files using this utility.

Go SDK: `cli/command`: Move `PrettyPrint` utility to `cli/command/formatter`.

- A picture of a cute animal (not mandatory but encouraged)

This utility was only used internally, and has no external consumers;
move it to the "formatter" package, which is also imported in all files
using this utility.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added status/2-code-review kind/refactor PR's that refactor, or clean-up code area/go-sdk Changes affecting the Go SDK impact/go-sdk Noteworthy (compatibility changes) in the Go SDK labels Mar 9, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2025

Codecov Report

Attention: Patch coverage is 43.33333% with 17 lines in your changes missing coverage. Please review.

Project coverage is 59.26%. Comparing base (2eec746) to head (ce3090c).
Report is 11 commits behind head on master.

❌ Your patch status has failed because the patch coverage (43.33%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5916   +/-   ##
=======================================
  Coverage   59.26%   59.26%           
=======================================
  Files         357      357           
  Lines       29771    29771           
=======================================
  Hits        17645    17645           
  Misses      11153    11153           
  Partials      973      973           
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thaJeztah thaJeztah added this to the 28.0.2 milestone Mar 10, 2025
@thaJeztah thaJeztah merged commit bc57a03 into docker:master Mar 10, 2025
110 checks passed
@thaJeztah thaJeztah deleted the move_command_prettyprint branch March 10, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/go-sdk Changes affecting the Go SDK impact/go-sdk Noteworthy (compatibility changes) in the Go SDK kind/refactor PR's that refactor, or clean-up code status/2-code-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants