Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opts: remove uses pkg/errors, and move swarm-specific opts to a separate package #5907

Merged
merged 3 commits into from
Mar 10, 2025

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Mar 8, 2025

opts: use stdlib errors and touch-up some errors

  • remove uses of github.com/pkg/errors
  • slight improvement on handling parsing errors
  • add some test-cases

opts: move swarm-specific options to a separate package

This prevents users of the CLI that don't implement swarm-related
features from depending on the swarm API types.

- Human readable description for the release notes

Go SDK: Deprecate `opts.PortOpt`, `opts.ConfigOpt` and `opts.SecretOpt`. These types were moved to the `opts/swarmopts` package.

- A picture of a cute animal (not mandatory but encouraged)

- remove uses of github.com/pkg/errors
- slight improvement on handling parsing errors
- add some test-cases

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2025

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.31%. Comparing base (2eec746) to head (d0d91bb).
Report is 32 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5907      +/-   ##
==========================================
+ Coverage   59.26%   59.31%   +0.04%     
==========================================
  Files         357      357              
  Lines       29771    29782      +11     
==========================================
+ Hits        17645    17666      +21     
+ Misses      11153    11146       -7     
+ Partials      973      970       -3     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This prevents users of the CLI that don't implement swarm-related
features from depending on the swarm API types.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added impact/deprecation status/2-code-review kind/refactor PR's that refactor, or clean-up code area/go-sdk Changes affecting the Go SDK labels Mar 8, 2025
@thaJeztah thaJeztah requested review from vvoland and Benehiko March 10, 2025 16:49
@thaJeztah thaJeztah added this to the 28.0.2 milestone Mar 10, 2025
@thaJeztah thaJeztah merged commit 64b5617 into docker:master Mar 10, 2025
107 checks passed
@thaJeztah thaJeztah deleted the opts_cleanup branch March 10, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/go-sdk Changes affecting the Go SDK impact/deprecation kind/refactor PR's that refactor, or clean-up code status/2-code-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants