Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[27.x backport] Optimise docker stats to not require clearing the whole screen #5635

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

thaJeztah
Copy link
Member

Instead of clearing the whole screen and then writing the new stats, we now write the new stats on top of the old text, and then clear the remaining text.

This is a more efficient way to update the stats, as it avoids the flickering that happens when the screen is cleared and rewritten.

(cherry picked from commit cb2f95c)

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Instead of clearing the whole screen and then writing the new stats,
we now write the new stats on top of the old text, and then clear
the remaining text.

This is a more efficient way to update the stats, as it avoids the
flickering that happens when the screen is cleared and rewritten.

Signed-off-by: Giedrius Jonikas <giedriusj1@gmail.com>
(cherry picked from commit cb2f95c)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

@laurazard @vvoland backporting this one as this is a follow-up to #5586, which was backported (#5588)

@thaJeztah thaJeztah changed the title Optimise docker stats to not require clearing the whole screen [27.x backport] Optimise docker stats to not require clearing the whole screen Nov 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 58.54%. Comparing base (877668c) to head (39d73af).
Report is 3 commits behind head on 27.x.

Additional details and impacted files
@@            Coverage Diff             @@
##             27.x    #5635      +/-   ##
==========================================
- Coverage   58.55%   58.54%   -0.02%     
==========================================
  Files         346      346              
  Lines       29329    29335       +6     
==========================================
  Hits        17173    17173              
- Misses      11178    11184       +6     
  Partials      978      978              
---- 🚨 Try these New Features:

@laurazard laurazard merged commit af56ef5 into docker:27.x Nov 19, 2024
98 of 102 checks passed
@thaJeztah thaJeztah deleted the 27.x_backport_improve_noflickr branch November 19, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants