Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0 backport] contrib/completion: remove aufs, legacy overlay #4302

Merged

Conversation

thaJeztah
Copy link
Member

The AuFS and (legacy) overlay storage drivers have been deprecated and removed, so remove them from the completion scripts.

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Verified

This commit was signed with the committer’s verified signature.
Josh-Cena Joshua Chen
The AuFS and (legacy) overlay storage drivers have been deprecated and
removed, so remove them from the completion scripts.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 73fbcde)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter
Copy link

Codecov Report

Merging #4302 (77541af) into 24.0 (f4b354f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             24.0    #4302   +/-   ##
=======================================
  Coverage   59.06%   59.06%           
=======================================
  Files         287      287           
  Lines       24784    24784           
=======================================
  Hits        14639    14639           
  Misses       9263     9263           
  Partials      882      882           

@thaJeztah thaJeztah merged commit 199b872 into docker:24.0 May 19, 2023
@thaJeztah thaJeztah deleted the 24.0_backport_completion_remove_aufs_overlay branch May 19, 2023 08:07
Copy link
Collaborator

@albers albers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member Author

Thanks @albers ! ❤️

(We were looking at preparing a v24.0.1 patch release with some fixes, and I wasn't sure if you had time to review, so asked colleagues on my team to have a quick look so that we could go ahead)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants