Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.10 backport] Add bash completion for available plugins #4091

Merged
merged 1 commit into from Mar 31, 2023
Merged

[20.10 backport] Add bash completion for available plugins #4091

merged 1 commit into from Mar 31, 2023

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Mar 12, 2023 •
edited

@crazy-max crazy-max requested a review from albers as a code owner March 12, 2023 13:02
@crazy-max crazy-max marked this pull request as draft March 13, 2023 15:43
@crazy-max crazy-max changed the title [20.10 backport] Add bash completion for docker-buildx plugin [20.10 backport] Add bash completion for available plugins Mar 13, 2023
@crazy-max crazy-max force-pushed the 20.10_backport_buildx-completion branch 2 times, most recently from 05db96a to 746249e Compare March 14, 2023 21:57
@crazy-max
Add bash completion for available plugins
928e470 
Signed-off-by: CrazyMax <github@crazymax.dev>
(cherry picked from commit aa0aa4a)
@crazy-max crazy-max force-pushed the 20.10_backport_buildx-completion branch from 746249e to 928e470 Compare March 17, 2023 14:06
@crazy-max crazy-max marked this pull request as ready for review March 21, 2023 12:06
@thaJeztah thaJeztah added this to the 20.10.24 milestone Mar 21, 2023
thaJeztah
thaJeztah approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

albers
albers approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@albers albers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 297e128 into docker:20.10 Mar 31, 2023
1 check passed
@crazy-max crazy-max deleted the 20.10_backport_buildx-completion branch April 8, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@albers albers albers approved these changes

Assignees
No one assigned
Labels
area/completion kind/enhancement status/2-code-review
Projects
None yet
Milestone
20.10.24
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crazy-max @thaJeztah @albers