handle attests correctly with provenance and sbom inputs #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
commented
Mar 26, 2024
crazy-max
force-pushed
the
fix-attests-provenance-sbom
branch
from
945a554
to
92318fe
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
fix-attests-provenance-sbom
branch
from
92318fe
to
96acf63
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
tonistiigi
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't detect usage of
attestsinput and therefore settingattests: type=provenance,mode=maxwill result in a duplicated provenance as we already set it automatically and build will fail with:This will also set
builder-idautomatically ifprovenanceis used inattestswhich was not the case before.To keep everything consistent across our flags such as
loadandpush,provenanceandsbominputs take precedence over ones set inattests