feat: warn about ignored inputs #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
favonia
force-pushed
the
warn-about-ignored-inputs
branch
from
52e0f98
to
2d7b2af
Compare
|
@crazy-max I believe all issues were addressed. 😀 |
Currently, several inputs can be silently ignored without any warnings. This change will issue a warning for each ignored input with a short explanation. Signed-off-by: favonia <favonia@gmail.com>
favonia
force-pushed
the
warn-about-ignored-inputs
branch
from
2d7b2af
to
8411d08
Compare
montekki
pushed a commit
to matter-labs/zksync-withdrawal-finalizer
that referenced
this pull request
Mar 8, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [docker/build-push-action](https://togithub.com/docker/build-push-action) | action | minor | `v5.1.0` -> `v5.2.0` | --- ### Release Notes <details> <summary>docker/build-push-action (docker/build-push-action)</summary> ### [`v5.2.0`](https://togithub.com/docker/build-push-action/releases/tag/v5.2.0) [Compare Source](https://togithub.com/docker/build-push-action/compare/v5.1.0...v5.2.0) - Disable quotes detection for `outputs` input by [@​crazy-max](https://togithub.com/crazy-max) in [docker/build-push-action#1074 - Warn about ignored inputs by [@​favonia](https://togithub.com/favonia) in [docker/build-push-action#1019 - Bump [@​docker/actions-toolkit](https://togithub.com/docker/actions-toolkit) from 0.14.0 to 0.18.0 in [docker/build-push-action#1070 - Bump undici from 5.26.3 to 5.28.3 in [docker/build-push-action#1057 **Full Changelog**: docker/build-push-action@v5.1.0...v5.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/matter-labs/zksync-withdrawal-finalizer). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMzAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIzMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
renovate bot
added a commit
to 4m-mazi/gh-test
that referenced
this pull request
Mar 9, 2024
#700) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [docker/build-push-action](https://togithub.com/docker/build-push-action) | action | minor | `v5.1.0` -> `v5.2.0` | [](https://securityscorecards.dev/viewer/?uri=github.com/docker/build-push-action) | --- ### Release Notes <details> <summary>docker/build-push-action (docker/build-push-action)</summary> ### [`v5.2.0`](https://togithub.com/docker/build-push-action/releases/tag/v5.2.0) [Compare Source](https://togithub.com/docker/build-push-action/compare/v5.1.0...v5.2.0) - Disable quotes detection for `outputs` input by [@​crazy-max](https://togithub.com/crazy-max) in [docker/build-push-action#1074 - Warn about ignored inputs by [@​favonia](https://togithub.com/favonia) in [docker/build-push-action#1019 - Bump [@​docker/actions-toolkit](https://togithub.com/docker/actions-toolkit) from 0.14.0 to 0.18.0 in [docker/build-push-action#1070 - Bump undici from 5.26.3 to 5.28.3 in [docker/build-push-action#1057 **Full Changelog**: docker/build-push-action@v5.1.0...v5.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/4m-mazi/gh-test). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMzAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIzMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, several inputs can be silently ignored without any warnings. This PR will issue a warning for each ignored input with a short explanation. I actually complained about the silent input ignoring in other issues/PRs, but since this is an open-source project, I suppose I can just make a PR. 😄 If this PR is accepted, I also hope future ignore inputs will come with appropriate warnings.