cache: move gha cache save to post state #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
post-cache
branch
5 times, most recently
from
c026dab
to
996c8de
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
nicks
approved these changes
Mar 15, 2024
|
|
||
| const fixturesDir = path.join(__dirname, 'fixtures'); | ||
|
|
||
| describe('cache', () => { |
There was a problem hiding this comment.
for my own education - what does itg in the filename cache.test.itg.ts stand for?
There was a problem hiding this comment.
this is using a dedicated jest config for integration tests
actions-toolkit/jest.config.itg.ts
Line 22 in cbcf885
this way we can run each them on dedicated runners on ci:
actions-toolkit/.github/workflows/test.yml
Lines 82 to 94 in cbcf885
https://github.com/docker/actions-toolkit/blob/main/jest.config.ts is for unit tests only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up #241
This moves github actions cache save handling in post step like it's currently done with official actions such as
actions/setup-go.